Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move key run commands implementation into era based #237

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Sep 2, 2023

Changelog

- description: |
    Move `key` run commands implementation into era based
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Only the implementation has been moved into era-based to minimise the size of the PR. The PR diff appears smaller if view by commits.

A future PR will make make the era-based run command era-sensitive and export them in the CLI.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 2, 2023 20:44
@newhoggy newhoggy force-pushed the newhoggy/move-key-run-commands-implementation-into-era-based branch from a992f96 to 0b045c9 Compare September 4, 2023 14:43
@newhoggy newhoggy force-pushed the newhoggy/move-key-run-commands-implementation-into-era-based branch from 0b045c9 to e98c8a9 Compare September 5, 2023 00:58
@newhoggy newhoggy added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 57b5e4e Sep 5, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/move-key-run-commands-implementation-into-era-based branch September 5, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants