Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify era handling #277

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Simplify era handling #277

merged 2 commits into from
Sep 22, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Sep 14, 2023

Changelog

- description: |
    Simplify era handling
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 14, 2023 10:22
@newhoggy newhoggy force-pushed the newhoggy/simplify-era-handling branch from adae480 to dfb230f Compare September 15, 2023 06:49
@newhoggy newhoggy force-pushed the newhoggy/simplify-era-handling branch from dfb230f to 01e05fb Compare September 16, 2023 08:21
@newhoggy newhoggy force-pushed the newhoggy/simplify-era-handling branch from 01e05fb to fdb0ec3 Compare September 22, 2023 09:24
@newhoggy newhoggy added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit d9dddc5 Sep 22, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/simplify-era-handling branch September 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants