Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify toTxOutInAnyEra #393

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

newhoggy
Copy link
Contributor

Changelog

- description: |
    Simplify `toTxOutInAnyEra`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR proves that AlonzoEraOnly is a false eon.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

refScript <- caseByronToAlonzoOrBabbageEraOnwards
(const (pure ReferenceScriptNone))
(\wb -> getReferenceScript wb refScriptFp)
era
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good example of how you could use eons to handle each feature independently which simplifies code a lot.

@newhoggy newhoggy force-pushed the newhoggy/simplify-toTxOutInAnyEra branch 2 times, most recently from c376570 to 74ae06e Compare October 19, 2023 15:45
@newhoggy newhoggy marked this pull request as ready for review October 19, 2023 15:49
@newhoggy newhoggy force-pushed the newhoggy/simplify-toTxOutInAnyEra branch from 74ae06e to c154476 Compare October 19, 2023 15:50
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Beware to remove the SRP when time has come.

@newhoggy newhoggy merged commit c154476 into main Oct 20, 2023
14 of 35 checks passed
@newhoggy newhoggy deleted the newhoggy/simplify-toTxOutInAnyEra branch October 20, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants