Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cardano-api-8.28.0.0 #394

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Conversation

newhoggy
Copy link
Contributor

Changelog

- description: |
    Simplify `toTxOutInAnyEra`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR proves that AlonzoEraOnly is a false eon.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 20, 2023 10:29
@newhoggy newhoggy changed the title Newhoggy/simplify to tx out in any era Upgrade to cardano-api-8.28.0.0 Oct 20, 2023
@newhoggy newhoggy force-pushed the newhoggy/simplify-toTxOutInAnyEra branch from f30a8c1 to 01b94c8 Compare October 20, 2023 10:30
@newhoggy newhoggy requested review from a team as code owners October 20, 2023 10:30
)
era

datum <- caseByronToMaryOrAlonzoEraOnwards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@newhoggy newhoggy added this pull request to the merge queue Oct 21, 2023
Merged via the queue into main with commit 30373af Oct 21, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/simplify-toTxOutInAnyEra branch October 21, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants