-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usages of assertFileOccurences by comparisons with golden files (1/n) #426
Conversation
d20ab39
to
9d81ccb
Compare
H.assertFileOccurences 1 "Governance proposal" actionFile | ||
|
||
H.assertEndsWithSingleNewline actionFile | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed, because we actually do a nearly-full (only the cbor Hex gets ignored) comparison against a golden file.
I could have put more in this PR, but since I'm off tomorrow (Friday), let's try to merge it sooner than later. |
import qualified Hedgehog.Extras.Test.Golden as H | ||
|
||
hprop_golden_governanceActionCreateConstitution :: Property | ||
hprop_golden_governanceActionCreateConstitution = | ||
hprop_golden_governance_action_create_constitution :: Property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changelog
Context
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist