Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split governance MIRTransferConstructor #427

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Nov 2, 2023

Changelog

- description: |
    Split governance `MIRTransferConstructor`
    Add `babbage governance create-genesis-key-delegation-certificate`
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The MIRTransferConstructor was previously shared between to commands. Split this constructor so that the constructor is no longer shared.

Add babbage governance create-genesis-key-delegation-certificate

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/split-GovernanceMIRTransfer-constructor branch from f84aa1c to e8956ac Compare November 2, 2023 11:53
@newhoggy newhoggy marked this pull request as ready for review November 2, 2023 11:53
makeMIRCertificate $
case direction of
TransferToReserves -> MirCertificateRequirements w Ledger.TreasuryMIR mirTarget
TransferToTreasury -> MirCertificateRequirements w Ledger.ReservesMIR mirTarget
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why reserves are matched to treasury and vice versa.

Copy link
Contributor

@carbolymer carbolymer Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last two arguments are pot and target. The pot is the source I guess. This would mean: from treasury and from reserves respectively as far as I understand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was confusingly named in ledger so TransferDirection was created to make it more obvious what was happening.

@newhoggy newhoggy added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot merged commit e4f32e8 into main Nov 2, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants