Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cardano-api to 8.30 #430

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Nov 2, 2023

Changelog

- description: |
    - Upgrade cardano-api to 8.30 
      https://github.com/input-output-hk/cardano-api/blob/main/cardano-api/CHANGELOG.md#83000
    - Remove usage of stake pool keys as credentials
      https://github.com/input-output-hk/cardano-cli/pull/412
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Note

Note to reviewers: this PR should be reviewed on commit-by-commit basis. 4e97da7 was already reviewed and approved in: #412

This PR consists of two commits:

This PR requires:

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/integrate-api-8.30 branch from 99b59f7 to ef144e0 Compare November 3, 2023 09:06
@carbolymer carbolymer requested review from a team as code owners November 3, 2023 09:06
@carbolymer carbolymer added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit c2c19d7 Nov 3, 2023
21 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/integrate-api-8.30 branch November 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants