Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining uses of IsCardanoEra #434

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Nov 4, 2023

Changelog

- description: |
    Remove remaining uses of `IsCardanoEra`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

We use IsCardanoEra in a small number of remaining places. Some of these already use CardanoEra. Modify the code to rely solely on CardanoEra instead.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review November 4, 2023 02:32
@newhoggy newhoggy added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 10, 2023
@newhoggy newhoggy added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 8bde151 Nov 10, 2023
21 checks passed
@newhoggy newhoggy deleted the newhoggy/remove-remaining-uses-of-IsCardanoEra branch November 10, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants