Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sbe variable name for the type is ShelleyBasedEra #66

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jul 9, 2023

Changelog

- description: |
    Rename `era` to `sbe` where the type is `ShelleyBasedEra`
  compatibility: no-api-changes
  type: maintenance

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review July 9, 2023 00:44
@newhoggy newhoggy changed the title Rename era to sbe where the type is ShelleyBasedEra Use era variable name for the type is ShelleyBasedEra Jul 9, 2023
@newhoggy newhoggy changed the title Use era variable name for the type is ShelleyBasedEra Use sbe variable name for the type is ShelleyBasedEra Jul 9, 2023
@newhoggy newhoggy force-pushed the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch 2 times, most recently from cd29c71 to f270da8 Compare July 10, 2023 11:38
@newhoggy newhoggy force-pushed the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch from f270da8 to 4d8a546 Compare July 10, 2023 11:39
@newhoggy newhoggy added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit 3d7eb3d Jul 11, 2023
15 of 17 checks passed
@newhoggy newhoggy deleted the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch July 11, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants