Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new tx-out flags #1429

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Test new tx-out flags #1429

merged 1 commit into from
Jul 11, 2023

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Jun 2, 2023

Description

This fixes #1417 adding tests to new flags (--consumed-tx-out , --prune-tx-out ) that were introduced which deal with tx-out consuming and pruning.

Also a slight restructure to start tests on feature flags

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@Cmdv Cmdv force-pushed the 1417-txout-migration-tests branch from 5dd019d to 2feca47 Compare June 9, 2023 11:29
@Cmdv Cmdv marked this pull request as ready for review June 15, 2023 15:20
kderme
kderme previously approved these changes Jun 20, 2023
Copy link
Contributor

@kderme kderme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like great start! We can either try to merge this and then you can add more tests on a separate pr, or you can append more tests in this pr.

@Cmdv Cmdv force-pushed the 1417-txout-migration-tests branch 3 times, most recently from 2de8eb6 to adca10f Compare June 23, 2023 10:11
@Cmdv Cmdv requested a review from a team as a code owner June 23, 2023 10:11
@Cmdv Cmdv force-pushed the 1417-txout-migration-tests branch from adca10f to 31b1b17 Compare July 3, 2023 11:09
@Cmdv Cmdv requested a review from kderme July 3, 2023 12:08
kderme
kderme previously approved these changes Jul 4, 2023
Copy link
Contributor

@kderme kderme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great first step for #1429. The last commit add pruning tests to Alonzo era maybe needs a better name or a squash? Since there are no tests in Alonzo era

@Cmdv Cmdv force-pushed the 1417-txout-migration-tests branch 2 times, most recently from e9525b1 to a22e5c7 Compare July 7, 2023 19:37
@Cmdv Cmdv requested a review from a team July 10, 2023 09:35
@Cmdv Cmdv force-pushed the 1417-txout-migration-tests branch from 1256052 to b6a937c Compare July 10, 2023 16:51
Copy link
Contributor

@sgillespie sgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cmdv Cmdv merged commit 542198e into master Jul 11, 2023
6 of 9 checks passed
@iohk-bors iohk-bors bot deleted the 1417-txout-migration-tests branch July 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for consumed and pruned tx_out migrations
3 participants