-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test new tx-out flags #1429
Test new tx-out flags #1429
Conversation
5dd019d
to
2feca47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like great start! We can either try to merge this and then you can add more tests on a separate pr, or you can append more tests in this pr.
2de8eb6
to
adca10f
Compare
adca10f
to
31b1b17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great first step for #1429. The last commit add pruning tests to Alonzo era maybe needs a better name or a squash? Since there are no tests in Alonzo era
e9525b1
to
a22e5c7
Compare
1256052
to
b6a937c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This fixes #1417 adding tests to new flags (
--consumed-tx-out
,--prune-tx-out
) that were introduced which deal with tx-out consuming and pruning.Also a slight restructure to start tests on feature flags
Checklist
fourmolu
(which can be run withscripts/fourmolize.sh
Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.