Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hydra failures #1491

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Fix Hydra failures #1491

merged 2 commits into from
Aug 25, 2023

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Aug 22, 2023 •
edited

Description

As of commit 1437235, migrations require PostgreSQL 12+. This change:

  • Runs tests with PostgreSQL 12
  • Runs tests with non-static PostgreSQL

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie
fix: Test with postgresql 12
f2eabc4 
As of commit 1437235, migrations require
PostgreSQL 12+
@sgillespie sgillespie changed the title fix: Test with postgres-12 Fix Hydra failures Aug 23, 2023
@sgillespie sgillespie marked this pull request as ready for review August 23, 2023 14:49
@sgillespie sgillespie requested review from a team as code owners August 23, 2023 14:49
kderme
kderme approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@kderme kderme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

angerman
angerman approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! 👍

@Cmdv Cmdv merged commit 13bba91 into IntersectMBO:master Aug 25, 2023
3 checks passed
@sgillespie sgillespie deleted the fix/ci-failures branch August 25, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

@kderme kderme kderme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgillespie @angerman @kderme @Cmdv