Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new flags #1558

Merged
merged 15 commits into from
Nov 13, 2023
Merged

Add new flags #1558

merged 15 commits into from
Nov 13, 2023

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Nov 9, 2023 •
edited

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@kderme kderme requested review from a team as code owners November 9, 2023 07:51
sgillespie
sgillespie previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sgillespie sgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kderme kderme changed the title Add a --disable-gov flag Add a --disable-gov and --disable-shelley flag Nov 12, 2023
Cmdv
Cmdv previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@kderme kderme changed the title Add a --disable-gov and --disable-shelley flag Add new flags Nov 13, 2023
@kderme kderme merged commit 433af0f into master Nov 13, 2023
18 of 22 checks passed
@iohk-bors iohk-bors bot deleted the kderme/conway-flag branch November 13, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgillespie sgillespie sgillespie left review comments

@Cmdv Cmdv Cmdv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kderme @sgillespie @Cmdv