Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add build arg to include genesis files #296

Merged
merged 1 commit into from
Sep 9, 2020
Merged

feat: Add build arg to include genesis files #296

merged 1 commit into from
Sep 9, 2020

Conversation

rhyslbw
Copy link
Contributor

@rhyslbw rhyslbw commented Sep 9, 2020

Context

Closes #260

Proposed Solution

  • Add Dockerfile build ARG, defaulting to mainnet

Important Changes Introduced

  • Mounting genesis files for mainnet or testnet is now a build time concern, although custom network config can still be mounted at runtime.
  • Genesis files are now nested in a top level config dir in the container

@rhyslbw rhyslbw added the enhancement New feature or request label Sep 9, 2020
@rhyslbw rhyslbw self-assigned this Sep 9, 2020
@rhyslbw rhyslbw merged commit 41232a0 into master Sep 9, 2020
@rhyslbw rhyslbw deleted the feature/docker-default-genesis branch September 9, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rhyslbw rhyslbw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place /genesis dir in docker image
1 participant
@rhyslbw