workbench: indentation, comments and better error messages

IntersectMBO · May 31, 2023 · 2ef3682 · 2ef3682
1 parent e9c5959
commit 2ef3682
Show file tree

Hide file tree

Showing 3 changed files with 166 additions and 95 deletions.
diff --git a/nix/workbench/backend/nomad.sh b/nix/workbench/backend/nomad.sh
@@ -824,7 +824,6 @@ backend_nomad() {
       local nomad_task_driver=$(envjqr   'nomad_task_driver')
       local one_tracer_per_node=$(envjqr 'one_tracer_per_node')
 
-      # TODO: Make it in parallel ?
       msg "Fetch logs ..."
 
       # Download healthcheck(s) logs.

diff --git a/nix/workbench/lib.sh b/nix/workbench/lib.sh
@@ -247,7 +247,7 @@ git_repo_commit_description() {
 wait_fail_any () {
   local processes=("$@")
   # There are any processes left?
-  if test -n "${processes[*]}"
+  if test -n "${processes[*]:-}"
   then
     local wait_exit_status
     local exited_process
@@ -263,7 +263,7 @@ wait_fail_any () {
       fi
     done
     # Something else to wait for?
-    if test -n "${processes_p[*]}"
+    if test -n "${processes_p[*]:-}"
     then
       # Keep waiting or kill 'em all ?'
       if test "${wait_exit_status}" -eq 0