Add TODOs about initial nonces

IntersectMBO · Jul 3, 2020 · af519a6 · af519a6
1 parent 6ae236a
commit af519a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/cardano-node/src/Cardano/Node/Protocol/Cardano.hs b/cardano-node/src/Cardano/Node/Protocol/Cardano.hs
@@ -191,6 +191,10 @@ mkConsensusProtocolCardano NodeByronProtocolConfiguration {
     --
     -- WARNING: chains using different values of this parameter will be
     -- mutually incompatible.
+    --
+    -- TODO: This should be replaced with the hash of the Shelley genesis
+    -- config JSON file, which should be taken as an argument/configuration
+    -- parameter.
     initialNonce = NeutralNonce
 
 

diff --git a/cardano-node/src/Cardano/Node/Protocol/Shelley.hs b/cardano-node/src/Cardano/Node/Protocol/Shelley.hs
@@ -107,6 +107,11 @@ mkConsensusProtocolShelley NodeShelleyProtocolConfiguration {
     --
     -- WARNING: chains using different values of this parameter will be
     -- mutually incompatible.
+    --
+    -- TODO: This should also be replaced with the hash of the Shelley genesis
+    -- config JSON file, which should be taken as an argument/configuration
+    -- parameter. But be careful, all testnets so far have used NeutralNonce,
+    -- changing the value will require starting a new testnet.
     initialNonce = NeutralNonce
 
 readGenesis :: GenesisFile