Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - Indicate graceful shutdown with a log message #2648

Closed
tdiesler opened this issue Apr 23, 2021 · 2 comments
Closed

[FR] - Indicate graceful shutdown with a log message #2648

tdiesler opened this issue Apr 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@tdiesler
Copy link
Contributor

Internal/External
External

Area
Cardano Node

Describe the feature you'd like

Currently, there is no indication in the log of graceful shutdown. i.e. you cannot tell whether the process was killed and will take > 15min to restart (because of block data re-validation) or gracefully shut down with no additional restart time

Describe alternatives you've considered

None. IMHO, it'd be a simple/useful addition

Additional context / screenshots

More context about this is given in #2608 and #2627
@tdiesler tdiesler added the enhancement New feature or request label Apr 23, 2021
This was referenced Apr 23, 2021
Closed
Closed
@jbgi
Copy link
Contributor

jbgi commented Jun 8, 2021

Just checked and actually there is a log:

Shutting down..

when killed with SIGINT. The log is absent when killed with SIGTERM.

@tdiesler
Copy link
Contributor Author

tdiesler commented Jun 8, 2021

Yes, this is out of date

@tdiesler tdiesler closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbgi @tdiesler