Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain density assumptions #272

Closed
CodiePP opened this issue Oct 31, 2019 · 1 comment
Closed

Chain density assumptions #272

CodiePP opened this issue Oct 31, 2019 · 1 comment
Assignees
@dcoutts
Labels
WIP Work In Progress (cannot be merged yet)

Comments

@CodiePP
Copy link
Contributor

CodiePP commented Oct 31, 2019 •
edited

the calculation of chain density (#250) makes the assumption that the length of an epoch depends on the parameter k = 2160 (10x in Byron). In case of Praos, epochs will likely be shorter.

TODO in cardano-node/src/Cardano/Tracing/Tracers.hs#L186

This is a reminder that this will not be the case in Shelley and so the code needs to be adapted.
@CodiePP CodiePP added the WIP Work In Progress (cannot be merged yet) label Oct 31, 2019
@CodiePP CodiePP mentioned this issue Oct 31, 2019
Merged
@deepfire
Copy link
Contributor

deepfire commented Dec 21, 2020 •
edited

fragmentChainDensity in the tracing code is now k-agnostic, this issue is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcoutts dcoutts

Labels
WIP Work In Progress (cannot be merged yet)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepfire @dcoutts @CodiePP