Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the shelley from scatch doc for recent CLI changes #1000

Merged
merged 1 commit into from May 19, 2020
Merged

Update the shelley from scatch doc for recent CLI changes #1000

merged 1 commit into from May 19, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented May 18, 2020

Mostly --network-magic vs --testnet-magic

erikd
erikd approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erikd
Copy link
Contributor

erikd commented May 19, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit f7c5654 into master May 19, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/doc-update-shelley-from-scratch branch May 19, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@disassembler disassembler disassembler approved these changes

@intricate intricate Awaiting requested review from intricate

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@mrBliss mrBliss Awaiting requested review from mrBliss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcoutts @erikd @disassembler