cli: Add 'shelley query ledger-state' command #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/query-ledger-state
branch
3 times, most recently
from
666051d
to
3611e19
Compare
erikd
commented
May 22, 2020
erikd
commented
May 22, 2020
| @@ -155,27 +192,27 @@ runQueryStakeDistribution network mOutFile = do | |||
| let ptclClientInfo = pClientInfoCodecConfig . protocolClientInfo $ mkNodeClientProtocolTPraos | |||
| tip <- liftIO $ withIOManager $ \iomgr -> | |||
| getLocalTip iomgr ptclClientInfo network sockPath | |||
| stakeDistr <- firstExceptT NodeLocalStateQueryError $ | |||
| stakeDist <- firstExceptT NodeLocalStateQueryError $ | |||
There was a problem hiding this comment.
These changes were required to avoid name shadowing warnings.
erikd
force-pushed
the
erikd/query-ledger-state
branch
from
3611e19
to
3bee0d9
Compare
intricate
reviewed
May 22, 2020
erikd
force-pushed
the
erikd/query-ledger-state
branch
from
3bee0d9
to
d636485
Compare
This command queries the node to the LedgerState to be returned as CBOR-in-CBOR. If the node and the cli are compatible, the LedgerState will be printed as JSON. If they are incompatible it will be printed as generic decoded CBOR.
erikd
force-pushed
the
erikd/query-ledger-state
branch
from
d636485
to
ba755ab
Compare
intricate
approved these changes
May 22, 2020
Jimbo4350
reviewed
May 22, 2020
| => Network | ||
| -> SocketPath | ||
| -> Point blk | ||
| -> ExceptT LocalStateQueryError IO (Either LByteString (Ledger.LedgerState TPraosStandardCrypto)) |
There was a problem hiding this comment.
Shouldn't we move that LByteString error into LocalStateQueryError as a new constructor?
There was a problem hiding this comment.
No, these really are two different things. If CBOR decoding is successful, the return the LedgerState. If decoding fails, return the ByteString.
There was a problem hiding this comment.
Jimbo4350
approved these changes
May 22, 2020
|
bors r+ |
dcoutts
approved these changes
May 22, 2020
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.