Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shelley cardano-cli error rendering functions #1021

Merged
merged 1 commit into from
May 26, 2020
Merged

Add shelley cardano-cli error rendering functions #1021

merged 1 commit into from
May 26, 2020

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/shelley-rendering-errors branch from 0129bfe to cd34e09 Compare May 22, 2020 13:58
intricate
intricate suggested changes May 22, 2020
View reviewed changes
cardano-cli/src/Cardano/CLI/Shelley/Run.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Genesis.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Genesis.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Node.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Query.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Query.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Transaction.hs Outdated Show resolved Hide resolved
@intricate intricate force-pushed the jordan/shelley-rendering-errors branch 2 times, most recently from 0a17f78 to ef3947d Compare May 25, 2020 15:50
@kevinhammond kevinhammond added this to Review in progress in CLI Revision May 25, 2020
erikd
erikd requested changes May 25, 2020
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change those two FilePath parameters in to VerificationKeyFile/SigningKeyFile in cardano-cli/src/Cardano/CLI/Shelley/Run/Node.hs /

Other than that this looks good.

cardano-cli/src/Cardano/CLI/Shelley/Run/Genesis.hs
firstExceptT ShelleyGenesisCmdKeyGenError $ runColdKeyGen (OperatorKey GenesisDelegateKey) vkeyPath skeyPath
firstExceptT ShelleyGenesisCmdOperationalCert $
firstExceptT ShelleyGenesisCmdOperatorKeyGenError $ runColdKeyGen (OperatorKey GenesisDelegateKey) vkeyPath skeyPath
firstExceptT (ShelleyGenesisCmdWriteOperationalCertError ocertCtrPath) $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Jimbo4350 @intricate
Add shelley error rendering functions
9add4b5 
Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
@intricate intricate force-pushed the jordan/shelley-rendering-errors branch from ef3947d to 9add4b5 Compare May 26, 2020 05:15
@intricate intricate requested review from erikd and intricate May 26, 2020 05:15
CLI Revision automation moved this from Review in progress to Reviewer approved May 26, 2020
@erikd
Copy link
Contributor

erikd commented May 26, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit e168f1b into master May 26, 2020
CLI Revision automation moved this from Reviewer approved to Done May 26, 2020
@iohk-bors iohk-bors bot deleted the jordan/shelley-rendering-errors branch May 26, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@intricate intricate intricate approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@mrBliss mrBliss Awaiting requested review from mrBliss

Assignees
No one assigned
Labels
None yet
Projects
No open projects
CLI Revision
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jimbo4350 @erikd @intricate