CAD-1085: Port in TUI, bug fix. #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350 and
mrBliss
as code owners
intricate
reviewed
May 27, 2020
| RealProtocolMode -> Text.pack $ "Port: " <> show (naPort <$> nodeAddr ncli) | ||
| RealProtocolMode -> Text.pack $ "Port: " <> | ||
| case naPort <$> nodeAddr ncli of | ||
| Nothing -> "-" |
There was a problem hiding this comment.
Is this what we want to display in the Nothing case? Or is there another means by which we can identify the node?
There was a problem hiding this comment.
Or is there another means by which we can identify the node?
I don't know it.
intricate
approved these changes
May 27, 2020
erikd
approved these changes
May 28, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes a small bug with
Portin TUI: no moreJust.