CAD-1132 trace block size in AdoptedBlock event #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodiePP
added
enhancement
CodiePP
requested review from
dcoutts,
erikd,
intricate and
Jimbo4350
as code owners
mrBliss
approved these changes
May 29, 2020
CodiePP
force-pushed
the
cad-1132-trace-block-size
branch
from
8e4ed92
to
e7a8573
Compare
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
CodiePP
force-pushed
the
cad-1132-trace-block-size
branch
from
e7a8573
to
a4735fe
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the block's size in the traced event AdoptedBlock.
this simplifies analysis of benchmarking results.
the size is available from the block's header. Thanks @mrBliss for pointing this out!