Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-1385: Show KES values in LiveView. #1503

Merged
merged 1 commit into from
Aug 6, 2020
Merged

CAD-1385: Show KES values in LiveView. #1503

merged 1 commit into from
Aug 6, 2020

Conversation

denisshevchenko
Copy link
Contributor

@denisshevchenko denisshevchenko commented Jul 20, 2020 •
edited

Add KES period and KES remaining in LiveView.

Related to #1372.

Please note that if the node doesn't have KES-information (if it was launched with Byron-protocol) KES-related fields in TUI will be hidden.

Screenshot:

withKES

CodiePP
CodiePP approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@CodiePP CodiePP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@denisshevchenko denisshevchenko mentioned this pull request Jul 23, 2020
Merged
iohk-bors bot added a commit to input-output-hk/cardano-benchmarking that referenced this pull request Jul 24, 2020
@iohk-bors
Merge #137
9bd3ac9 
137: CAD-1385: KES-info in RTView. r=CodiePP a=denisshevchenko

Show KES-info in RTView.

Corresponding changes in `cardano-node`: IntersectMBO/cardano-node#1503

Please note that, if the node is launched with an old protocol (without KES-info), corresponding fields don't hide, but show `"—"` instead. The reason is this: in `Grid view` we have a table where each row corresponds to metric. Suppose three nodes were connected to RTView, but one of them (node `A`) works with `Byron` and two another (`B` and `C`) - with `Cardano`. In this case I still have the same 3 KES-related rows, but for `A` it will be show `"—"`, and for `B` and `C` - real values.

Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
@CodiePP CodiePP linked an issue Jul 24, 2020 that may be closed by this pull request
[FR] - Inlcude KES period and KES remaining in live view #1372
Closed
@CodiePP
Copy link
Contributor

CodiePP commented Jul 24, 2020

@denisshevchenko could you add a screenshot
that would probably speed up the review process

@denisshevchenko
Copy link
Contributor Author

@CodiePP Done (the screenshot was added in a description).

intricate
intricate approved these changes Jul 27, 2020
View reviewed changes
cardano-node/src/Cardano/Node/TUI/Drawing.hs
Comment on lines +215 to +217
else [ padTop (Pad 1) $ txt "Start KES period:"
, txt "KES period:"
, txt "KES remaining:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alignment seems a bit odd. Perhaps you meant:

Suggested change
else [ padTop (Pad 1) $ txt "Start KES period:"
, txt "KES period:"
, txt "KES remaining:"
else [ padTop (Pad 1) $ txt "Start KES period:"
, txt "KES period:"
, txt "KES remaining:"

@CodiePP CodiePP added this to Reviewer approved in ActiveBoard Jul 30, 2020
@CodiePP
Copy link
Contributor

CodiePP commented Aug 6, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 6, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 48aa330 into master Aug 6, 2020
ActiveBoard automation moved this from Reviewer approved to Done Aug 6, 2020
@iohk-bors iohk-bors bot deleted the cad-1385-liveview-kes-info branch August 6, 2020 19:18
@7-of-9
Copy link

7-of-9 commented Aug 21, 2020

Updated BP to 1.19.0, and not seeing KES period info in the LiveView mode, FYI. It's just missing, output is identical to 1.18.0.

BP node was created from scratch on mainnet 1.18.0 post-Shelley fork, so I don't think its' due to "was launched with Byron-protocol")...

@mrBliss
Copy link
Contributor

mrBliss commented Aug 21, 2020

Updated BP to 1.19.0, and not seeing KES period info in the LiveView mode, FYI. It's just missing, output is identical to 1.18.0.

BP node was created from scratch on mainnet 1.18.0 post-Shelley fork, so I don't think its' due to "was launched with Byron-protocol")...

Please see #1742

@mrBliss mrBliss mentioned this pull request Aug 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@CodiePP CodiePP CodiePP approved these changes

@intricate intricate intricate approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@mrBliss mrBliss Awaiting requested review from mrBliss

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
ActiveBoard
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Inlcude KES period and KES remaining in live view
6 participants
@denisshevchenko @CodiePP @7-of-9 @mrBliss @Jimbo4350 @intricate