Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pProtocol CLI parser default value to CardanoProtocol #1515

Merged
merged 1 commit into from Jul 22, 2020
Merged

Change pProtocol CLI parser default value to CardanoProtocol #1515

merged 1 commit into from Jul 22, 2020

Conversation

intricate
Copy link
Contributor

No description provided.

@intricate intricate self-assigned this Jul 21, 2020
kantp
kantp approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@kantp kantp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @intricate!

@kantp
Copy link
Contributor

kantp commented Jul 21, 2020

bors merge

iohk-bors bot added a commit that referenced this pull request Jul 21, 2020
@iohk-bors @intricate
Merge #1515
1926f38 
1515: Change pProtocol CLI parser default value to CardanoProtocol r=kantp a=intricate



Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
kevinhammond
kevinhammond approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@kevinhammond kevinhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@disassembler
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 21, 2020
@iohk-bors @intricate
Merge #1515
635b835 
1515: Change pProtocol CLI parser default value to CardanoProtocol r=disassembler a=intricate



Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
dcoutts
dcoutts approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions below, both related to the fact that the Byron slots-per-epoch and Shelley slots-per-epoch are different values and so it's useful to be specific in the variable names and help messages.

cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs Outdated Show resolved Hide resolved
@intricate intricate force-pushed the intricate/default-cardano-mode branch from a22f659 to c64cda1 Compare July 22, 2020 00:42
@intricate intricate force-pushed the intricate/default-cardano-mode branch from c64cda1 to c3ed53f Compare July 22, 2020 00:48
@intricate
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 22, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit a0eb636 into master Jul 22, 2020
@iohk-bors iohk-bors bot deleted the intricate/default-cardano-mode branch July 22, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@kantp kantp kantp approved these changes

@kevinhammond kevinhammond kevinhammond approved these changes

@erikd erikd Awaiting requested review from erikd

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@mrBliss mrBliss Awaiting requested review from mrBliss

@newhoggy newhoggy Awaiting requested review from newhoggy

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@intricate intricate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@intricate @kantp @disassembler @dcoutts @kevinhammond