Default byron-witness-count CLI option to 0 #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
requested review from
dcoutts,
erikd,
Jimbo4350,
mrBliss and
newhoggy
as code owners
intricate
force-pushed
the
intricate/1489-default-byron-witness-count
branch
from
f7d0616
to
2981a50
Compare
dcoutts
approved these changes
Jul 21, 2020
|
Should squash and then merge. |
Co-authored-by: Duncan Coutts <duncan@well-typed.com>
intricate
force-pushed
the
intricate/1489-default-byron-witness-count
branch
from
101392e
to
df1c2b4
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1489.
Most users probably won't utilize this CLI option, so it makes sense to default it to 0 as opposed to forcing them to specify a value.