Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize byron commands similarly to shelley commands (maintaining backwards compatibility) #1609

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jul 30, 2020

  • All the previous commands exist at the top level (but hidden in the help) however there is one breaking change. Previous commands under byron had to be moved under governance. These were:
 create-update-proposal   Create an update proposal.
 create-proposal-vote     Create an update proposal vote.
 submit-update-proposal   Submit an update proposal.
 submit-proposal-vote     Submit a proposal vote.

Previous grouping:

cabal exec cardano-cli                                                                                                                                       
cardano-cli - utility to support a variety of key operations (genesis
generation, migration, pretty-printing..) for different system generations.

Usage: cardano-cli (Byron specific commands | Shelley specific commands | 
                     Miscellaneous commands)

Available options:
  --version                Show the cardano-cli version
  -h,--help                Show this help text

Byron specific commands
  byron                    Byron node operation commands
  genesis                  Create genesis.
  print-genesis-hash       Compute hash of a genesis file.
  keygen                   Generate a signing key.
  to-verification          Extract a verification key in its base64 form.
  signing-key-public       Pretty-print a signing key's verification key (not a
                           secret).
  signing-key-address      Print address of a signing key.
  migrate-delegate-key-from
                           Migrate a delegate key from an older version.
  issue-delegation-certificate
                           Create a delegation certificate allowing the
                           delegator to sign blocks on behalf of the issuer
  check-delegation         Verify that a given certificate constitutes a valid
                           delegation relationship between keys.
  submit-tx                Submit a raw, signed transaction, in its on-wire
                           representation.
  issue-genesis-utxo-expenditure
                           Write a file with a signed transaction, spending
                           genesis UTxO.
  issue-utxo-expenditure   Write a file with a signed transaction, spending
                           normal UTxO.
  get-tip                  Get the tip of your local node's blockchain
  validate-cbor            Validate a CBOR blockchain object.
  pretty-print-cbor        Pretty print a CBOR file.

Shelley specific commands
  shelley                  Shelley specific commands

Miscellaneous commands
  version                  Show the cardano-cli version

New grouping:

cabal exec cardano-cli                                                                                                                                     
cardano-cli - utility to support a variety of key operations (genesis
generation, migration, pretty-printing..) for different system generations.

Usage: cardano-cli (Byron specific commands | Shelley specific commands | 
                     Miscellaneous commands)

Available options:
  --version                Show the cardano-cli version
  -h,--help                Show this help text

Byron specific commands
  byron                    Byron specific commands

Shelley specific commands
  shelley                  Shelley specific commands

Miscellaneous commands
  version                  Show the cardano-cli version

@KtorZ
Copy link
Contributor

KtorZ commented Jul 30, 2020

@Jimbo4350 Thanks for tagging! Do I understand it right that this is only a change in the byron sub-section of the cardano-cli 🤔 ?

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Jul 30, 2020

@Jimbo4350 Thanks for tagging! Do I understand it right that this is only a change in the byron sub-section of the cardano-cli thinking ?

This is correct. The byron subsection has been replaced but all the other original arguments remain the same and are hidden.

@Jimbo4350
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 31, 2020

@iohk-bors iohk-bors bot merged commit 7d68626 into master Jul 31, 2020
@iohk-bors iohk-bors bot deleted the jordan/reorganize-byron-commands branch July 31, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants