Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve json topology parsing errors #1634

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Improve json topology parsing errors #1634

merged 1 commit into from
Aug 11, 2020

Conversation

Jimbo4350
Copy link
Contributor

Relevant issue: #1446

@Jimbo4350 Jimbo4350 changed the title Improve json topology errors Improve json topology parsing errors Aug 4, 2020
@Jimbo4350 Jimbo4350 linked an issue Aug 4, 2020 that may be closed by this pull request
[BUG] - cardano-node shows misleading error when using strings for port/valency in topology.json #1446
Closed
@erikd
Copy link
Contributor

erikd commented Aug 11, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 815cec2 into master Aug 11, 2020
@iohk-bors iohk-bors bot deleted the jordan/json-error branch August 11, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@intricate intricate Awaiting requested review from intricate

@mrBliss mrBliss Awaiting requested review from mrBliss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - cardano-node shows misleading error when using strings for port/valency in topology.json
3 participants
@Jimbo4350 @erikd @newhoggy