cli: Improve stake-address-info query output #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
requested review from
dcoutts,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
intricate
approved these changes
Aug 13, 2020
| -> Aeson.Value | ||
| delegAndRwdToJson (k, (d, r)) = | ||
| Aeson.object | ||
| [ "address" .= toKey k |
There was a problem hiding this comment.
I would rename this toKey function since the resulting value is not being used as a key in a map anymore.
Alternatively, since toKey isn't actually being reused, factor it out entirely and do serialiseAddress (StakeAddress (toShelleyNetwork nw) k).
There was a problem hiding this comment.
Renamed to renderAddress .
The previous output was a JSON object, with a key for each address. The new output is a list of homogenous objects so that the same object parser should work for all objects in the list. Closes: #1546
erikd
force-pushed
the
erikd/stake-address-info
branch
from
bf35afa
to
8dcbece
Compare
|
bors merge |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.