CAD-2166: delegation map size trace & export (with UTxO size) to prometheus #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
force-pushed
the
cad-2166-delegation-map-prometheus
branch
from
e57275a
to
69e8d4f
Compare
deepfire
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
deepfire
changed the title
deepfire
force-pushed
the
cad-2166-delegation-map-prometheus
branch
from
69e8d4f
to
b2e017f
Compare
newhoggy
approved these changes
Dec 4, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 4, 2020
2158: CAD-2166: delegation map size trace & export (with UTxO size) to prometheus r=deepfire a=deepfire 1. extend `LedgerQueries` with `delegMapSize` -- to query the effective delegation map size 1. trace `delegMapSize` with `TraceStartLeadershipCheck` 1. export both `utxoSize` and `delegMapSize` as metrics 1. move all metrics to the `cardano.node.metrics` namespace. This affects: - `cardano.node.Forge.metrics` - `cardano.node.ChainDB.metrics` WARNING: breaking change -- see point №4. This also simplifies configuration, making the following unnecessary: https://github.com/input-output-hk/cardano-node/blob/master/configuration/cardano/mainnet-config.json#L66-L71 cc @disassembler @denisshevchenko Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
…artLeadershipCheck
deepfire
force-pushed
the
cad-2166-delegation-map-prometheus
branch
from
b2e017f
to
d85c7c1
Compare
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 4, 2020
2158: CAD-2166: delegation map size trace & export (with UTxO size) to prometheus r=deepfire a=deepfire 1. extend `LedgerQueries` with `delegMapSize` -- to query the effective delegation map size 1. trace `delegMapSize` with `TraceStartLeadershipCheck` 1. export both `utxoSize` and `delegMapSize` as metrics 1. move all metrics to the `cardano.node.metrics` namespace. This affects: - `cardano.node.Forge.metrics` - `cardano.node.ChainDB.metrics` WARNING: breaking change -- see point №4. This also simplifies configuration, making the following unnecessary: https://github.com/input-output-hk/cardano-node/blob/master/configuration/cardano/mainnet-config.json#L66-L71 cc @disassembler @denisshevchenko Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 4, 2020
2175: Pass a metrics tracer to teeTraceChainTip r=dcoutts a=intricate After #2158, it seems that ChainDB metrics were mistakenly being logged to `cardano.node` instead of `cardano.node.metrics`. This PR fixes that. Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LedgerQuerieswithdelegMapSize-- to query the effective delegation map sizedelegMapSizewithTraceStartLeadershipCheckutxoSizeanddelegMapSizeas metricscardano.node.metricsnamespace. This affects:cardano.node.Forge.metricscardano.node.ChainDB.metricsWARNING: breaking change -- see point №4. This also simplifies configuration, making the following unnecessary:
https://github.com/input-output-hk/cardano-node/blob/master/configuration/cardano/mainnet-config.json#L66-L71
cc @disassembler @denisshevchenko