Network tracers #2178
Merged
Network tracers #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
coot
force-pushed
the
coot/network-tracers
branch
from
c884877
to
8254e3f
Compare
intricate
reviewed
Dec 7, 2020
coot
force-pushed
the
coot/network-tracers
branch
from
8254e3f
to
a7a4a8d
Compare
Trace the agancy together with a mini-protocol message tag. Ouroboros-Network was able to do that for some time, this patch provides necessary tracing class instance changes.
When using 'ScText' format, Show instances provide much more readable logging output.
coot
force-pushed
the
coot/network-tracers
branch
from
a7a4a8d
to
49942cf
Compare
deepfire
reviewed
Dec 11, 2020
| getSeverityAnnotation BlockFetch.CompletedBlockFetch {} = Info | ||
| getSeverityAnnotation BlockFetch.CompletedFetchBatch {} = Info | ||
| getSeverityAnnotation BlockFetch.RejectedFetchBatch {} = Info | ||
| getSeverityAnnotation BlockFetch.ClientTerminating {} = Notice | ||
|
|
There was a problem hiding this comment.
@coot, do you think it can be:
Suggested change
| getSeverityAnnotation BlockFetch.ClientTerminating {} = Notice | |
| getSeverityAnnotation _ = Info |
?
There was a problem hiding this comment.
We will have something like 20 hot peers, so these messages will rather be sparse. I thought that initially its better to start with Notice and we can move to Info later. Are you ok with it @deepfire ?
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 11, 2020
2178: Network tracers r=coot a=coot This PR improves network tracers; originally done in `coot/p2p-integration` branch, but this part is indepentend of p2p changes in `ouroboros-network`. This PR consists of two patches: - Improved mini-protocol tracers Which includes agency together with the mini-protocol message tag. - networking trace using show instances rather than json values Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
newhoggy
approved these changes
Dec 14, 2020
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves network tracers; originally done in
coot/p2p-integrationbranch,but this part is indepentend of p2p changes in
ouroboros-network. This PR consists of two patches:Improved mini-protocol tracers
Which includes agency together with the mini-protocol message tag.
networking trace using show instances rather than json values