Eliminate use of the LastKnownBlockVersion-Major for Shelley based eras #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
approved these changes
Dec 7, 2020
mrBliss
approved these changes
Dec 7, 2020
intricate
approved these changes
Dec 7, 2020
The node config file entries LastKnownBlockVersion-Major and -Minor are now only used for the Byron era. For the Shelley-based eras (Shelley, Allegra, Mary) we now hard-code the numbers. There is no reason for them to be configurable. We will change the consensus later to automate it and eliminate the config record entries entirely.
dcoutts
force-pushed
the
dcoutts/node-config-last-known-version
branch
from
1d896a6
to
702e760
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node config file entries LastKnownBlockVersion-Major and -Minor are
now only used for the Byron era.
For the Shelley-based eras (Shelley, Allegra, Mary) we now hard-code the
numbers. There is no reason for them to be configurable. We will change
the consensus later to automate it and eliminate the config record
entries entirely.