Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fromShelleyAddr to also require a ShelleyBasedEra parameter #2253

Merged
merged 1 commit into from Jan 27, 2022
Merged

Update fromShelleyAddr to also require a ShelleyBasedEra parameter #2253

merged 1 commit into from Jan 27, 2022

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

@Jimbo4350 Jimbo4350 force-pushed the jordan/from-shelley-addr-make-explicit branch from 786ca2f to 30a5c3d Compare March 3, 2021 15:42
dcoutts
dcoutts approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I agree it makes sense for this to be an explicit param, rather than an implicit class-based param.

@Jimbo4350
Copy link
Contributor Author

bors r+

@Jimbo4350 Jimbo4350 force-pushed the jordan/from-shelley-addr-make-explicit branch 2 times, most recently from de94b7f to e195e9a Compare March 18, 2021 11:30
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 6, 2021
@iohk-bors @Jimbo4350
Merge #2253
3f4dbcc 
2253: Update fromShelleyAddr to also require a ShelleyBasedEra parameter r=Jimbo4350 a=Jimbo4350



Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 6, 2021

Build failed:

@Jimbo4350 Jimbo4350 force-pushed the jordan/from-shelley-addr-make-explicit branch from e195e9a to 88d6b32 Compare January 27, 2022 16:06
@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 27, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 13604cb into master Jan 27, 2022
@iohk-bors iohk-bors bot deleted the jordan/from-shelley-addr-make-explicit branch January 27, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@dcoutts dcoutts dcoutts approved these changes

@erikd erikd Awaiting requested review from erikd

@intricate intricate Awaiting requested review from intricate

@mrBliss mrBliss Awaiting requested review from mrBliss

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jimbo4350 @newhoggy @dcoutts