Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old IPC api from cardano-api #2319

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Remove old IPC api from cardano-api #2319

merged 4 commits into from
Feb 10, 2021

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jan 28, 2021 •
edited

  • Removes old IPC
  • Adjusts modules exposed by cardano-api

@Jimbo4350 Jimbo4350 mentioned this pull request Feb 1, 2021
Merged
DavidEichmann
DavidEichmann approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@DavidEichmann DavidEichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good :-)

@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 10, 2021
@iohk-bors @Jimbo4350
Merge #2319
ae0232d 
2319: Remove old IPC api from cardano-api r=Jimbo4350 a=Jimbo4350

- Removes old IPC
- Adjusts modules exposed by `cardano-api`

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 10, 2021

Build failed:

@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 10, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 91f25c2 into master Feb 10, 2021
@iohk-bors iohk-bors bot deleted the jordan/remove-old-IPC branch February 10, 2021 12:06
dcoutts
dcoutts reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts left review comments

@DavidEichmann DavidEichmann DavidEichmann approved these changes

@erikd erikd Awaiting requested review from erikd

@intricate intricate Awaiting requested review from intricate

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jimbo4350 @dcoutts @DavidEichmann