Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs on --host[-ipv6]-addr options #2431

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix docs on --host[-ipv6]-addr options #2431

merged 1 commit into from
Mar 2, 2021

Conversation

cblp
Copy link
Contributor

@cblp cblp commented Mar 2, 2021 •
edited

Make them consistent with the real behaviour.

Fix #2352

@cblp
Fix docs on --host[-ipv6]-addr options
223c03a 
Make them consistent with the real behaviour.

Fix #2352
@cblp
Copy link
Contributor Author

cblp commented Mar 2, 2021

@karknu please review

@cblp cblp mentioned this pull request Mar 2, 2021
Closed
@Jimbo4350
Copy link
Contributor

@cblp It's a good idea to include the issue you are solving in the main comment of this PR. Anything like "Closes #2352" would suffice

@cblp
Copy link
Contributor Author

cblp commented Mar 2, 2021

@Jimbo4350 I put the bug report reference to the commit and forgot to double it in the PR. Now fixed.

@Jimbo4350 Jimbo4350 self-requested a review March 2, 2021 13:58
Jimbo4350
Jimbo4350 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would wait for approval from @karknu as well.

karknu
karknu approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cblp
Copy link
Contributor Author

cblp commented Mar 2, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 2, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit a9a0590 into master Mar 2, 2021
@iohk-bors iohk-bors bot deleted the ipv4v6-2 branch March 2, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karknu karknu karknu approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - IPV6 addresses fail to parse
3 participants
@cblp @Jimbo4350 @karknu