CAD-2717: cardano node service extensions #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
force-pushed
the
cad-2712-cardano-node-service
branch
2 times, most recently
from
7dfd84b
to
e1e6de9
Compare
jbgi
approved these changes
Mar 4, 2021
Jimbo4350
approved these changes
Mar 4, 2021
deepfire
force-pushed
the
cad-2712-cardano-node-service
branch
from
e1e6de9
to
c55a2f3
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 4, 2021
2443: CAD-2717: cardano node service extensions r=deepfire a=deepfire 1. Allow the `topology` path config option to also be a string. 2. Add the `executable` option, to allow customising the way the node is started -- so that we can, for example, use `cabal run -- cardano-node`. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
topologypath config option to also be a string.executableoption, to allow customising the way the node is started -- so that we can, for example, usecabal run -- cardano-node.