Modify submit-api to accept cbor transactions instead #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
DavidEichmann,
dcoutts,
erikd and
Jimbo4350
as code owners
newhoggy
force-pushed
the
modify-submit-api-to-accept-cbor-transactions-instead
branch
from
67bacb5
to
1610818
Compare
erikd
reviewed
Mar 16, 2021
|
This comment is the context: #2370 (comment) My understanding is that CBOR without envelope is what the old version of We would probably do some MIME type thing to support both, I haven't figured that out yet. |
newhoggy
force-pushed
the
modify-submit-api-to-accept-cbor-transactions-instead
branch
from
1610818
to
870e643
Compare
erikd
approved these changes
Mar 16, 2021
dcoutts
previously requested changes
Mar 16, 2021
newhoggy
force-pushed
the
modify-submit-api-to-accept-cbor-transactions-instead
branch
from
870e643
to
ef2968d
Compare
newhoggy
force-pushed
the
modify-submit-api-to-accept-cbor-transactions-instead
branch
2 times, most recently
from
9ba8d31
to
fc0afd7
Compare
Jimbo4350
approved these changes
Mar 17, 2021
| ] | ||
| -> Either RawCborDecodeError b | ||
| deserialiseAnyOf ts te = let (es, as) = partitionEithers results in maybe (errors es) Right (listToMaybe as) | ||
| where |
There was a problem hiding this comment.
An alternative suggestion: 862f692
There was a problem hiding this comment.
I've taken your suggestion to use list instead of non-empty-list, but also fixed up the logic like this: If there is at least successful decode, always take the first one.
newhoggy
force-pushed
the
modify-submit-api-to-accept-cbor-transactions-instead
branch
from
b52b91c
to
06ca656
Compare
|
bors merge |
|
Build succeeded: |
iohk-bors
bot
deleted the
modify-submit-api-to-accept-cbor-transactions-instead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.