Integration with peer2peer networking #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
DavidEichmann,
dcoutts,
deepfire,
denisshevchenko,
erikd,
JaredCorduan,
Jimbo4350,
jutaro,
karknu,
MarcFontaine,
nc6 and
newhoggy
as code owners
|
Although |
karknu
approved these changes
Nov 12, 2021
coot
force-pushed
the
p2p-master
branch
2 times, most recently
from
c1e8140
to
8f80f31
Compare
newhoggy
reviewed
Nov 15, 2021
newhoggy
reviewed
Nov 15, 2021
newhoggy
reviewed
Nov 15, 2021
newhoggy
approved these changes
Nov 15, 2021
coot
force-pushed
the
p2p-master
branch
2 times, most recently
from
719b19c
to
b568136
Compare
Jimbo4350
reviewed
Nov 15, 2021
Jimbo4350
reviewed
Nov 15, 2021
Jimbo4350
requested changes
Nov 15, 2021
coot
force-pushed
the
p2p-master
branch
3 times, most recently
from
37ab9a8
to
7f37808
Compare
coot
force-pushed
the
p2p-master
branch
2 times, most recently
from
39c11bf
to
757e891
Compare
Jimbo4350
approved these changes
Nov 16, 2021
This commit provides: * p2p options * p2p traces * p2p topology file format * integration with changes in `ouroboros-consensus` and `ouroboros-network`. * the provided default p2p config values are for a relay node As of now, using p2p mode is not as thoroughly verified as the current implementation, and thus it is __not__ supported. We also do not guarantee, at this stage, that the p2p mode is forward compatible, specifically the version of `NodeToNodeV_8` might entirely change its scope in the future which can break p2p nodes. Co-authored-by: Armando Santos <bolt12@users.noreply.github.com> Co-authored-by: Karl Knutsson <karknu@users.noreply.github.com> Co-authored-by: Marcin Szamotulski <coot@users.noreply.github.com>
It also removes `MockNodeTopolgy` (todo: why?) Co-authored-by: Armando Santos <bolt12@users.noreply.github.com> Co-authored-by: Karl Knutsson <karknu@users.noreply.github.com> Co-authored-by: Marcin Szamotulski <coot@users.noreply.github.com>
TODO: do we want to commit it or keep it in a branch? Co-authored-by: Armando Santos <bolt12@users.noreply.github.com> Co-authored-by: Karl Knutsson <karknu@users.noreply.github.com> Co-authored-by: Marcin Szamotulski <coot@users.noreply.github.com>
- Fixed chairman tests for P2P and NonP2P modes - Fixed topology format generation in chairman tests. - Updated config file and topology file - Added P2P Switch flag to chairman config files - Added mkTopologyConfig function to switch accordingly as well - Disable P2P Mode for Byron and Shelley tests - General chairman-tests refactoring to support P2P Switch - Fix valency in ByronShelley - Updated config files
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 16, 2021
3363: Integration with peer2peer networking r=coot a=coot This PR integrates with peer2peer networking and allows to run a node in either mode: * non-p2p: the only officially supported version * p2p: unverified and unsupported p2p mode This also includes: * a new topology file format for p2p nodes * a mechanism to reload topology file on SIGHUP signal - network trace instances: use ToJSON or ToObject instances - network trace instances: peer selection traces - network trace instances: ToJSON instances - consensus trace instances: trace termination reason - P2P / NonP2P cardano-node - Update p2p topology configuration via the SIGHUP signal - Removed MonoLocalBinds extension - topology file: improved parsing error message - Improve NetworkTopology generator - byron-mainnet configuration: added p2p trace options - p2p topology file for cardano mainnet - Document the p2p topology file - Updated cardano-node-chairman - Updated trace-dispatcher and trace-forward libraries - Updated tx-generator - Updated cardano-testnet package - Code cleanup in Tracing.Config - nixos service: add p2p topology support. - nixos-service: Add space-cost profiling support - nixos-service: Add space-heap profiling support Co-authored-by: Marcin Szamotulski <profunctor@pm.me> Co-authored-by: Armando Santos <armandoifsantos@gmail.com> Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io> Co-authored-by: John Lotoski <john.lotoski@iohk.io>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, denisshevchenko, jutaro, and/or MarcFontaine.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
denisshevchenko
approved these changes
Nov 16, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates with peer2peer networking and allows to run a node in either mode:
This also includes: