Porting ekg-direct metrics to new-tracing #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutaro
force-pushed
the
jutaro/ekg-direct-new-tracing
branch
from
15d7049
to
c97149a
Compare
cardano-node: remove old commented out
traceDispatcher: metricsTracer
jutaro
force-pushed
the
jutaro/ekg-direct-new-tracing
branch
from
af1cb58
to
ba921e7
Compare
deepfire
reviewed
May 19, 2022
| -- [p] -> fromText "\nPrivacy: " <> asCode (fromString (show p)) | ||
| -- l -> fromText "\nPrivacies: " | ||
| -- <> mconcat (intersperse (singleton ',') | ||
| -- (map (asCode . fromString . show) l)) |
There was a problem hiding this comment.
@jutaro, do we need this commented section?
There was a problem hiding this comment.
Removed, hope I can recover it one day
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct EKG is a way to record measurments without using the tracing system. We ported it over to new tracing, partly with using standard cardano-tracer, and partly with sending it directly to the EKGBackend