Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require decentralization parameter in protocol parameters #4051

Merged
merged 1 commit into from Jun 15, 2022
Merged

Do not require decentralization parameter in protocol parameters #4051

merged 1 commit into from Jun 15, 2022

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jun 14, 2022 •
edited

Fixes build-raw command and partially resolves #4033

Closes #3897

JaredCorduan
JaredCorduan approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem like a great way to unblock us until we have the time to handle the protocol parameters in an era-generic manor.

dcoutts
dcoutts approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good quick hack, and will be fine for now.

Do we have an open issue for the proper fix? We should not loose track of the proper solution.

@dcoutts dcoutts merged commit 6471c31 into master Jun 15, 2022
@iohk-bors iohk-bors bot deleted the jordan/adjust-toledgerparams-to-not-error-when-missing-decen-param branch June 15, 2022 09:57
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Jun 15, 2022
Open
@CarlosLopezDeLara
Copy link
Contributor

This is a good quick hack, and will be fine for now.

Do we have an open issue for the proper fix? We should not loose track of the proper solution.

#4054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@dcoutts dcoutts dcoutts approved these changes

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Jimbo4350 @CarlosLopezDeLara @JaredCorduan @dcoutts