tx-generator: Fix multi-threaded use of tx-streams. #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses #4428. |
|
Todo: Fix 'Selftest.testscript' |
MarcFontaine
force-pushed
the
mafo/tx-generator-cleanup3
branch
from
8b3ab14
to
0818647
Compare
|
bors r+ |
|
👎 Rejected by label |
mgmeier
approved these changes
Sep 20, 2022
MarcFontaine
requested review from
deepfire,
denisshevchenko,
jutaro,
fmaste and
cleverca22
as code owners
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 20, 2022
4442: tx-generator: Fix multi-threaded use of tx-streams. r=MarcFontaine a=MarcFontaine * Put the tx-streams behind an `MVar`. * Replace 'BechmarkTx' with generic 'NtoM'. * Remove 'RunBenchmarkAux' and cleanups. * Remove global state for 'TFee' and 'TTxAdditionalSize' Co-authored-by: Michael Karg <michael.karg@iohk.io> Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from cleverca22, deepfire, denisshevchenko, fmaste, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 20, 2022
4442: tx-generator: Fix multi-threaded use of tx-streams. r=MarcFontaine a=MarcFontaine * Put the tx-streams behind an `MVar`. * Replace 'BechmarkTx' with generic 'NtoM'. * Remove 'RunBenchmarkAux' and cleanups. * Remove global state for 'TFee' and 'TTxAdditionalSize' Co-authored-by: Michael Karg <michael.karg@iohk.io> Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from cleverca22, deepfire, denisshevchenko, fmaste, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Sep 20, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVar.