Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed severity of 'DiffusionErrored' log message #4465

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Changed severity of 'DiffusionErrored' log message #4465

merged 1 commit into from
Oct 25, 2022

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 22, 2022

It ought to be an Alert, these are terminal errors which require
immediate attention from an operator.

@coot coot self-assigned this Sep 22, 2022
@coot coot added the networking Issues and PRs related to networking label Sep 22, 2022
@coot
Changed severity of 'DiffusionErrored' log message
b0fa8ab 
It ought to be an `Alert`, these are terminal errors which require
immediate attention from an operator.
@coot coot force-pushed the coot/severity-of-diffusion-error branch from 1757c00 to b0fa8ab Compare October 21, 2022 12:32
@coot coot requested a review from a team as a code owner October 21, 2022 12:32
@coot
Copy link
Contributor Author

coot commented Oct 24, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Oct 24, 2022
@iohk-bors @coot
Merge #4465
8e46314 
4465: Changed severity of 'DiffusionErrored' log message r=coot a=coot

It ought to be an `Alert`, these are terminal errors which require
immediate attention from an operator.


Co-authored-by: Marcin Szamotulski <coot@coot.me>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 24, 2022

Timed out.

@coot
Copy link
Contributor Author

coot commented Oct 25, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 25, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit abce0f7 into master Oct 25, 2022
@iohk-bors iohk-bors bot deleted the coot/severity-of-diffusion-error branch October 25, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@deepfire deepfire Awaiting requested review from deepfire

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

Assignees

@coot coot

Labels
networking Issues and PRs related to networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coot @newhoggy @Jimbo4350