Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4493 bug - TxWitness text envelope format does not roundtrip in Shelley era #4501

Merged
merged 1 commit into from Oct 5, 2022
Merged

Fix 4493 bug - TxWitness text envelope format does not roundtrip in Shelley era #4501

merged 1 commit into from Oct 5, 2022

Conversation

Jimbo4350
Copy link
Contributor

Resolves: #4493

erikd
erikd requested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally applaud "Fix bug 4493" in the commit message, but the commit message really should briefly say what the bug was.

mkoura
mkoura approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@mkoura mkoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it fixes issue #4493

@Jimbo4350 Jimbo4350 force-pushed the jordan/4493-bug-fix branch 2 times, most recently from a4e23fd to a03072f Compare October 4, 2022 12:47
@Jimbo4350
Fix TxWitness text envelope formatting for the Shelley era
76beb9a 
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies.

Closes: #4493
@Jimbo4350
Copy link
Contributor Author

bors r+

@Jimbo4350 Jimbo4350 changed the title Fix 4493 bug Fix 4493 bug - TxWitness text envelope format does not roundtrip in Shelley era Oct 5, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 5, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8fa420b into master Oct 5, 2022
@iohk-bors iohk-bors bot deleted the jordan/4493-bug-fix branch October 5, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@mkoura mkoura mkoura approved these changes

@LudvikGalois LudvikGalois LudvikGalois approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - TextEnvelopeCddl error when assembling Shelley-era Tx body in CDDL format
4 participants
@Jimbo4350 @erikd @mkoura @LudvikGalois