Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cabal-3.8.1.0 #4549

Merged
merged 1 commit into from Oct 28, 2022
Merged

Upgrade to cabal-3.8.1.0 #4549

merged 1 commit into from Oct 28, 2022

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy force-pushed the upgrade-to-cabal-3.8.1.0 branch 2 times, most recently from af1602a to 32003c1 Compare October 24, 2022 09:32
@newhoggy newhoggy marked this pull request as ready for review October 24, 2022 09:33
cabal.project Outdated
Comment on lines 187 to 191
source-repository-package
type: git
location: https://github.com/astanin/moo
tag: dbda5e76ac3b4c72c805ec0cdb9bcdff7bb6247d
--sha256: 1mdj218hgh7s5a6b9k14vg9i06zxah0wa42ycdgh245izs8nfv0x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed (when using CHaP)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not, there is a patched version in CHaP. Also please don't add more without a clear justification!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried last it the build failed on moo. I'll create another PR without that commit to see if it happens again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the CHaP index state and it works now.

@newhoggy newhoggy force-pushed the upgrade-to-cabal-3.8.1.0 branch 2 times, most recently from 2ca4292 to 9903545 Compare October 24, 2022 13:39
@newhoggy
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 27, 2022
4549: Upgrade to cabal-3.8.1.0 r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
Update CHaP index state
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2022

Canceled.

@newhoggy
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 27, 2022
4549: Upgrade to cabal-3.8.1.0 r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2022

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 27, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from CarlosLopezDeLara, JaredCorduan, Jimbo4350, LudvikGalois, dcoutts, erikd, and/or input-output-hk/devops.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Jimbo4350
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 28, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit d533317 into master Oct 28, 2022
@iohk-bors iohk-bors bot deleted the upgrade-to-cabal-3.8.1.0 branch October 28, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants