Added features to tracing #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jutaro
commented
Feb 22, 2023
jutaro
commented
- Generated docu shows tracers, tracers with metrics, silent tracers according to current configuration
- Trace message shows tracers with metrics and silent tracers
jutaro
requested review from
Jimbo4350,
newhoggy,
deepfire,
coot,
mgmeier,
fmaste,
cleverca22 and
a team
as code owners
deepfire
reviewed
Feb 23, 2023
| @@ -5,7 +5,7 @@ | |||
| ### [Trace Messages](#trace-messages) | |||
|
|
|||
| 1. __BlockFetch__ | |||
| 1. __Client__ | |||
| 1. __Clientⓣ__ | |||
There was a problem hiding this comment.
Some strange unicode symbols added, here and below.
There was a problem hiding this comment.
In the generated TOC you will find the following annotations:
ⓣ This is the root of a tracer
ⓢ This tracer is silent by configuration
ⓜ This tracer carries metrics
deepfire
reviewed
Feb 23, 2023
deepfire
reviewed
Feb 23, 2023
Comment on lines
-4282
to
-4302
| ### Forge.KESInfo | ||
|
|
||
|
|
||
| > kesStartPeriod | ||
| > kesEndPeriod is kesStartPeriod + tpraosMaxKESEvo | ||
| > kesEvolution is the current evolution or /relative period/. | ||
|
|
||
|
|
||
| Severity: `Info` | ||
| Privacy: `Public` | ||
| Details: `DNormal` | ||
|
|
||
|
|
||
| From current configuration: | ||
|
|
||
| Backends: | ||
| `EKGBackend`, | ||
| `Stdout MachineFormat`, | ||
| `Forwarder` | ||
| Filtered `Visible` by config value: `Info` | ||
|
|
There was a problem hiding this comment.
Some documentation bits are gone -- is that intended?
There was a problem hiding this comment.
That's true. I had to remove it, because a more principled approach lead to that the docu generator is not working for this special case. But I have an idea how to fix this, but will be part of next PR.
jutaro
force-pushed
the
jutaro/tracer3-adds
branch
from
f4d2fb8
to
d8a4f04
Compare
deepfire
approved these changes
Feb 27, 2023
|
bors r+ |
|
Timed out. |
olgahryniuk
approved these changes
Feb 28, 2023
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 28, 2023
4625: Handle pipes r=Jimbo4350 a=LudvikGalois Fixes #4235 4908: Added features to tracing r=jutaro a=jutaro * Generated docu shows tracers, tracers with metrics, silent tracers according to current configuration * Trace message shows tracers with metrics and silent tracers Co-authored-by: Robert 'Probie' Offner <robert.offner@iohk.io> Co-authored-by: Yupanqui <jnf@arcor.de>
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.