Bench nomad sub-backends #5037
Merged
Bench nomad sub-backends #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmaste
force-pushed
the
bench-nomad-vault
branch
4 times, most recently
from
b3ee18d
to
66fbd60
Compare
fmaste
force-pushed
the
bench-nomad-vault
branch
from
30fead3
to
db9a23d
Compare
deepfire
reviewed
Apr 6, 2023
| describe-run ) | ||
| backend_nomad describe-run "$@" | ||
| ;; | ||
|
|
There was a problem hiding this comment.
@fmaste, you can simplify this passthrough very significantly -- you can see how the top-level wb does it, at the end of the file, when handling aliases.
There was a problem hiding this comment.
It was simpler, the way you recommend, but I used this form to debug and I kept it
deepfire
reviewed
Apr 6, 2023
| @@ -294,6 +299,7 @@ main() { | |||
| chaindb | c ) chaindb "$@";; | |||
| genesis | g ) genesis "$@";; | |||
| manifest | m ) manifest "$@";; | |||
| nomad | n ) wb_nomad "$@";; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nomadpodmanusing the podman task driver andnomadexecusing the exec task driver, and one cloud backendnomadcloudusing IOG infrastructure. This PR makes the distinction and usage between the three of them more clear.wb nomad) to reuse thewb publishcode for fetching the credentials (wb nomad vault) and make sub-backend agnostic the code that manages the life-cycle of Nomad Agents (wb nomad server|client start|stop).