Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration tests to cardano-node tests #5284

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 30, 2023

Description

These tests lived in cardano-cli, they do not test cardano-cli functionality at all and cardano-cli is soon to be moved to its own repository.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review May 30, 2023 00:32
@newhoggy newhoggy force-pushed the newhoggy/move-configuration-tests-to-cardano-node-tests branch from be3d09b to 5e41bbc Compare May 30, 2023 03:30
@newhoggy newhoggy force-pushed the newhoggy/move-configuration-tests-to-cardano-node-tests branch from 5e41bbc to f43e1c6 Compare May 30, 2023 07:26
@newhoggy newhoggy added this pull request to the merge queue May 30, 2023
Merged via the queue into master with commit 0cee8c6 May 30, 2023
18 of 22 checks passed
@iohk-bors iohk-bors bot deleted the newhoggy/move-configuration-tests-to-cardano-node-tests branch May 30, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants