Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated cardano-cli ping command #5313

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Updated cardano-cli ping command #5313

merged 1 commit into from
Jun 14, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Jun 9, 2023 •
edited

cardano-cli ping command compatible with cardano-node-8.1.0.

@coot coot force-pushed the coot/cardano-ping branch 2 times, most recently from 08a3775 to 8d9e9f1 Compare June 9, 2023 17:47
@coot coot changed the title coot/cardano ping Updated cardano-cli ping command Jun 9, 2023
@newhoggy newhoggy force-pushed the coot/cardano-ping branch 2 times, most recently from 1eca0d9 to 483be32 Compare June 12, 2023 02:53
@coot
Copy link
Contributor Author

coot commented Jun 12, 2023

Ups, it seems I overwrote your changes @newhoggy.

@coot
Copy link
Contributor Author

coot commented Jun 12, 2023

@newhoggy I think your CODEOWNER changes should be pushed as a separate PR, unless they are necessary for this PR to pass CI, so they're reviewed by the right people.

JaredCorduan
JaredCorduan approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bolt12
bolt12 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot force-pushed the coot/cardano-ping branch 2 times, most recently from 9191460 to 0a2c923 Compare June 14, 2023 17:53
@coot
Copy link
Contributor Author

coot commented Jun 14, 2023

@newhoggy there's something strange with the ci/hdyra-build:required. It fails running the golden tests with:

dist-newstyle/cache/plan.json: openBinaryFile: does not exist (No such file or directory)

@disassembler disassembler added this pull request to the merge queue Jun 14, 2023
Merged via the queue into master with commit a7803c2 Jun 14, 2023
19 of 22 checks passed
@iohk-bors iohk-bors bot deleted the coot/cardano-ping branch June 14, 2023 22:13
@newhoggy
Copy link
Contributor

This error happens when nix doesn't defined the necessary environment variables for the tests to find the binary it needs.

@mkoura mkoura mentioned this pull request Jun 15, 2023
Closed
@coot coot mentioned this pull request Jun 16, 2023
Merged
@coot coot added the cardano-ping Issues / PRs related to cardano-ping label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy approved these changes

@carbolymer carbolymer carbolymer approved these changes

@disassembler disassembler disassembler approved these changes

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@bolt12 bolt12 bolt12 approved these changes

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@LaurenceIO LaurenceIO Awaiting requested review from LaurenceIO

Assignees
No one assigned
Labels
cardano-ping Issues / PRs related to cardano-ping
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@coot @newhoggy @carbolymer @disassembler @JaredCorduan @bolt12 @jprider63