Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cardano node nixos service #5318

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Update cardano node nixos service #5318

merged 7 commits into from
Jun 15, 2023

Conversation

johnalotoski
Copy link
Contributor

@johnalotoski johnalotoski commented Jun 13, 2023 •
edited

Description

  • Migrate p2p topology to the latest format
  • Fix an ipv6 and socket activation option conflict
  • Fix (remove) a valency object present in accessPoints
  • Add systemd socket NoDelay config
  • Remove experimental protocol enablement from useNewTopology config default
  • Assert that systemd socket activation and p2p topology options are not used
  • Fix buildkite queue

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Required CI passes
  • Self-reviewed the diff

@johnalotoski johnalotoski marked this pull request as ready for review June 14, 2023 21:17
@johnalotoski johnalotoski requested review from a team, mgmeier and fmaste as code owners June 14, 2023 21:17
@disassembler disassembler added this pull request to the merge queue Jun 15, 2023
Merged via the queue into master with commit 68ee905 Jun 15, 2023
20 of 22 checks passed
@iohk-bors iohk-bors bot deleted the cardano-node-service-ipv6 branch June 15, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnalotoski @disassembler