Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move golden files to proper location #5339

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

newhoggy
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review June 17, 2023 18:35
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer carbolymer mentioned this pull request Jun 19, 2023
9 tasks
@newhoggy newhoggy force-pushed the newhoggy/move-golden-files-to-proper-location branch from 8146d77 to f146972 Compare June 20, 2023 04:37
@newhoggy newhoggy requested review from a team as code owners June 20, 2023 04:37
@newhoggy newhoggy force-pushed the newhoggy/move-golden-files-to-proper-location branch from be028cf to 25a2805 Compare June 20, 2023 08:20
@newhoggy newhoggy added this pull request to the merge queue Jun 20, 2023
Merged via the queue into master with commit 09c5830 Jun 20, 2023
20 of 22 checks passed
@iohk-bors iohk-bors bot deleted the newhoggy/move-golden-files-to-proper-location branch June 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants