cardano-node top level error handler #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
changed the title
coot
force-pushed
the
coot/node-exception-handler
branch
from
7b3d006
to
3a4c461
Compare
bolt12
requested changes
Jun 23, 2023
bolt12
approved these changes
Jul 3, 2023
newhoggy
approved these changes
Jul 3, 2023
The top level error handler for diffusion errors should dispatch one of the other methods. In particular it must rethrow async exceptions, and also prevents from printing `DiffusionError user interrupt` when `SIGINT` was received.
coot
force-pushed
the
coot/node-exception-handler
branch
from
3a4c461
to
d018f8b
Compare
Jimbo4350
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top level handler for diffusion errors should dispatch one of the
methods.
In particular it must rethrow async exceptions, and also prevents from
printing
DiffusionError user interruptwhenSIGINTwas received.